Repository navigation
Conversation
…Angular exit app example
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #3583
What is the current behavior?
Currently, the Angular "Exiting the App" examples inject
IonRouterOutletthrough the constructor. InAppComponent, where most apps put this, that resolves tonulland the first back press throws.What is the new behavior?
The examples now query the outlet with
@ViewChildand null-check it, with a sentence explaining why. Applied to v9 and v8.Does this introduce a breaking change?
Other information
Tested on Ionic 8 and 9, standalone and NgModule. The old snippet throws in all four, the new one exits at the root and navigates back elsewhere